Change csc/csr_matrix to array #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torressa
changed the title
|
@torressa does this mean we also need to update the required gurobipy version to 10.0.3 to ensure users get the fixes needed to work with scipy? If so can you please update that in pyproject.toml? |
|
@torressa I updated a few coo_matrix cases as well. Also, when updating things like this I think we should generally not remove old tests. Users might still pass a csr_matrix even if we no longer use it internally. So I duplicated the csr_array test here to cover both cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this has been fixed: Resolved in Gurobi v10.0.3: Compatibility issues with numpy 1.25 and scipy 1.11 should we change these occurences back to
_array?